Ticket #1456: url_multi_value.patch

turbogears/controllers.py

@@ -485 +485 @@
 
     Query parameters for the URL can be passed in as a dictionary in
     the second argument *or* as keyword parameters.
+
+    Values which are a list or a tuple are used to create multiple
+    key-value pairs.
     """
     if not isinstance(tgpath, basestring):
         tgpath = "/".join(list(tgpath))
@@ -504 +507 @@
     for key, value in tgparams.iteritems():
         if value is None:
             continue
-        if isinstance(value, unicode):
-            value = value.encode("utf8")
-        args.append("%s=%s" % (key, urllib.quote(str(value))))
+        if isinstance(value, (list, tuple)):
+            pairs = [(key, v) for v in value]
+        else:
+            pairs = [(key, value)]
+        for (k,v) in pairs:
+            if isinstance(value, unicode):
+                value = value.encode("utf8")
+            args.append("%s=%s" % (k, urllib.quote(str(v))))
     if args:
         result += "?" + "&".join(args)
     return result

turbogears/tests/test_controllers.py

@@ -564 +564 @@
             print e.urls
             assert "http://localhost/coolsite/root/subthing/foo" in e.urls
 
+    def test_multi_values(self):
+        testutil.createRequest("/")
+        assert url("/foo", bar=[1,2]) in \
+                ["/foo?bar=1&bar=2", "/foo?bar=2&bar=1"]
+        assert url("/foo", bar=("asdf","qwer")) in \
+                ["/foo?bar=qwer&bar=asdf", "/foo?bar=asdf&bar=qwer"]
 
     def tearDown(self):
         turbogears.config.update({"server.webpath" : ""})