Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #107 (closed defect: fixed)

Opened 14 years ago

Last modified 12 years ago

[PATCH] move widget CSS/JavaScript into sitetemplate

Reported by: kevin Owned by: anonymous
Priority: normal Milestone: 0.9
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

the sitetemplate (not master.kid) should be the one that manages putting the CSS and JavaScript? in place in a default setup.

Attachments

master.kid Download (783 bytes) - added by bloodearnest@… 14 years ago.
New master.kid, with just layout info, no TG magic
sitetemplate.kid Download (561 bytes) - added by bloodearnest@… 14 years ago.
Default sitetemplate with hooks for widget css/js

Change History

comment:1 Changed 14 years ago by bloodearnest@…

Have attached updated master.kid and sitetemplate.kid for this ticket. Based on revision 293.

Moved the css/js hooks from master to sitetemplate, tested it with all widgets. It worked, with the exception that the css links are correctly inserted, but the current widgets don't use the classes defined in the linked-to css, but I guess that's another issue.

I changed the hooks in sitetemplate to use py:replace="x.insert()" rather than $x.insert() as this prevents the kid commands appearing when viewing sitetemplate via a browser. Not that you'd want to do that, but better safe than sorry.

HTH

Changed 14 years ago by bloodearnest@…

New master.kid, with just layout info, no TG magic

Changed 14 years ago by bloodearnest@…

Default sitetemplate with hooks for widget css/js

comment:2 Changed 14 years ago by michele

  • Summary changed from move widget CSS/JavaScript into sitetemplate to [PATCH] move widget CSS/JavaScript into sitetemplate

I'm marking this with the [PATCH] prefix. Anyway I'm not sure if sitetemplate will be a standalone kid template. Kevin?

comment:3 Changed 14 years ago by kevin

  • Status changed from new to closed
  • Resolution set to fixed

Applied in [317]. Thanks!

Note: See TracTickets for help on using tickets.