Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1102 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

Dead code in controllers.py?

Reported by: bjourne Owned by: anonymous
Priority: normal Milestone:
Component: TurboGears Version: 0.9a6
Severity: normal Keywords:
Cc:

Description

The file trunk/turbogears/controllers.py has the lines:

except Invalid, error:
    if hasattr(error, "unpack_errors"):
        error = error.unpack_errors()
    elif hasattr(error, "error_dict"):
        error = error.error_dict
    if isinstance(error, dict):
        errors.update(error)
    else:
        errors = error

But this should be dead code. FormEncode's Invalid exception definitely always has the unpack_errors() method.

Change History

comment:1 Changed 13 years ago by alberto

  • Status changed from new to closed
  • Resolution set to fixed

Cleaned up among other things at #1853. Thanks for spotting it.

Alberto

Note: See TracTickets for help on using tickets.