Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1176 (closed defect: fixed)

Opened 12 years ago

Last modified 11 years ago

[PATCH] IE7: incorrect rendering with AutoCompleteField widget

Reported by: grover Owned by: alberto
Priority: normal Milestone: 1.0.1
Component: TG Widgets Version: 1.0b1
Severity: normal Keywords:
Cc: alberto

Description

I was having difficulty with by website rendering in IE7. I tracked it down to widgets/static/autocompletefield.css .autotextresults, the "width: 100%" line. Removing this fixed it. I will attach a pic of the rendering in IE7, and also the correct rendering (with "width:100%" removed)

Even under Firefox, the width line causes the horizontal scrollbar to appear when the dropdown appears. Very strange.

Attachments

bad.png Download (84.0 KB) - added by grover 12 years ago.
website under IE7 with width = 100%
good.png Download (84.3 KB) - added by grover 12 years ago.
exact same with width=100% removed. note horizontal scrollbar is not visible (correctly) and repeating background is visible
bug-quickstart.tar.bz2 Download (82.0 KB) - added by grover 12 years ago.
quickstart exhibiting problem
1176.patch Download (357 bytes) - added by roger.demetrescu 12 years ago.

Change History

Changed 12 years ago by grover

website under IE7 with width = 100%

Changed 12 years ago by grover

exact same with width=100% removed. note horizontal scrollbar is not visible (correctly) and repeating background is visible

comment:1 Changed 12 years ago by jorge.vargas

  • Milestone set to 1.0b3

will this break ie6 ? or other browser?

comment:2 Changed 12 years ago by roger.demetrescu

grover, can you provide us a small project that emulates your site ( http://bandradar.com) ? One that can reproduce the problem showed in bad.png.

My intention is to report if you patch will break IE6, FF1 or FF2.

I am pretty sure it will help other people to test it with Safari and Opera.

Thanks

Changed 12 years ago by grover

quickstart exhibiting problem

comment:3 Changed 12 years ago by grover

reproduced with FF2, and in a quickstarted project (attached). I added an AutoCompleteField to the welcome page. Make sure the browser is wide enough to not have a horizontal scroll bar at the bottom.

Type something in the autocomplete field. Horizontal scrollbar will appear at the bottom. Expected result: no scrollbar. This can be fixed as I describe above. This also results in much worse visual artifacts in IE7 (can't test IE6) but hopefully the weird scrollbar stuff in FF is enough to convince you this is broken?

Thanks -- Andy

comment:4 Changed 12 years ago by alberto

  • Milestone changed from 1.0b3 to 1.1

comment:5 Changed 12 years ago by roger.demetrescu

  • Summary changed from IE7: incorrect rendering with AutoCompleteField widget to [PATCH] IE7: incorrect rendering with AutoCompleteField widget

Hi Andy, sorry for taking so much time to look at it.

I've done some tests. IE6 run fine before and after I applied your patch.

The following browsers showed the weird scrollbar. And all of them looked fine after applying the patch:

  • IE 7 (windows)
  • Opera 9.10 (windows)
  • FF 2.0 (windows)
  • FF 1.5 (linux)
  • Konqueror 3.5 (linux)

So my vote is: lets apply it.... :)

I'm attaching your patch in diff format.

Changed 12 years ago by roger.demetrescu

comment:6 Changed 12 years ago by alberto

  • Milestone changed from 1.1 to 1.0.1

comment:7 Changed 12 years ago by alberto

  • Status changed from new to assigned
  • Owner changed from anonymous to alberto

comment:8 Changed 12 years ago by alberto

  • Status changed from assigned to closed
  • Resolution set to fixed

Comitted at [2368] Thanks! :) Alberto

comment:9 Changed 12 years ago by roger.demetrescu

  • Cc alberto added

That's weird...

I can see [2369] (as a merging from [2368]), but no [2368] ...

Internal Error

No changeset 2368 in the repository

Roger

comment:10 Changed 12 years ago by alberto

Geee! It's weird indeed! "The phantom commit"... I'll need to investigate this further...

Thanks for spotting it :)

Alberto

comment:11 Changed 12 years ago by alberto

Seems like a Trac bug:

jal:~/src/python/checkouts/turbogears alberto$ svn -r2368 log
------------------------------------------------------------------------
r2368 | alberto | 2007-01-15 12:44:43 +0100 (Mon, 15 Jan 2007) | 1 line

Fixing AutoCompleteField rendering in IE7. Closes #1176. Thanks grover and roger :)
------------------------------------------------------------------------

comment:12 Changed 12 years ago by alberto

... or a misconfiguration by our side ...

Note: See TracTickets for help on using tickets.