Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1231 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

[PATCH] built-in 'hash' being redefined in model.py

Reported by: dundeemt Owned by: alberto
Priority: normal Milestone: 1.0.1
Component: unassigned Version: trunk
Severity: trivial Keywords: identity, model, redefine
Cc: jgodoy@…

Description

When Identity is enabled, the _set_password password function of the User class unintentionally redefines the python built-in 'hash'. This originates in the quickstart template, model.py_tmpl @ lines 106-107 in the Trunk.

reference the discussion on the tg list  http://groups-beta.google.com/group/turbogears/browse_frm/thread/dcef9342d0aac15b/a2c3b3d6258a3516

I will be submitting a patch later today

Attachments

hash.patch Download (682 bytes) - added by dundeemt 11 years ago.
rename hash variable so unintended redefinition of built-in doesn't occur

Change History

Changed 11 years ago by dundeemt

rename hash variable so unintended redefinition of built-in doesn't occur

comment:1 Changed 11 years ago by dundeemt

  • Summary changed from built-in 'hash' being redefined in model.py to [PATCH] built-in 'hash' being redefined in model.py

patch uploaded

comment:2 Changed 11 years ago by alberto

  • Milestone changed from 1.0 to 1.0.1

comment:3 Changed 11 years ago by alberto

  • Owner changed from anonymous to alberto
  • Status changed from new to assigned

comment:4 Changed 11 years ago by alberto

  • Status changed from assigned to closed
  • Resolution set to fixed

Comitted at [2378]. More style/pylint improvements like this welcomed...

Thanks :)

Alberto

P.S. Please read diffing guidelines at my last comment in #1115

Note: See TracTickets for help on using tickets.