Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #125 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

form errors should be displayed by forms not widgets

Reported by: kevin Owned by: michele
Priority: normal Milestone: 0.9
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

Currently, the widgets are displaying the error messages associated with their values. The form objects should really control the display of these error messages (because they might all be displayed together at the top or alongside the widget, for example).

Attachments

ticket125.patch Download (8.5 KB) - added by michele 13 years ago.
The patch
125-another.patch Download (10.6 KB) - added by michele 13 years ago.
Last patch (warning, it's not finished)

Change History

comment:1 Changed 13 years ago by kevin

  • Status changed from new to closed
  • Resolution set to fixed

comment:2 Changed 13 years ago by kevin

  • Status changed from closed to reopened
  • Resolution fixed deleted

this isn't done after all.. not sure why I thought it was.

comment:3 Changed 13 years ago by michele

  • Status changed from reopened to new
  • Owner changed from anonymous to michele

Trying to work on this.

comment:4 Changed 13 years ago by michele

  • Summary changed from form errors should be displayed by forms not widgets to [PATCH] form errors should be displayed by forms not widgets

Done, I attach the patch.

Anyway we should wait for #114 to be committed since Karl has also refactored out the FormTable? into Form.

Changed 13 years ago by michele

The patch

comment:5 Changed 13 years ago by michele

I forgot to add that this patch still needs some more work on the FieldSet? widget.

comment:6 Changed 13 years ago by michele

I'm trying to finish this, I will submit a patch that doesn't refactor the TableForm? but only deals with error handling.

comment:7 Changed 13 years ago by michele

I will attach the last patch I've sent to Kevin back in December.

Warning, it's not finished, work is needed for the FieldSet? if IIRC and it also moves the error logic out of the widget so it should be tested well to check that it's not broken.

Changed 13 years ago by michele

Last patch (warning, it's not finished)

comment:8 Changed 13 years ago by kevin

  • Summary changed from [PATCH] form errors should be displayed by forms not widgets to form errors should be displayed by forms not widgets

I'm removing the patch tag until we have a completed patch.

comment:9 Changed 13 years ago by michele

My slightly modified widgets system addresses all the problems I mentioned and fixes this ticket.

comment:10 Changed 13 years ago by michele

  • Status changed from new to closed
  • Resolution set to fixed

Done... finally. :D

Note: See TracTickets for help on using tickets.