Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1327 (closed defect: duplicate)

Opened 12 years ago

Last modified 11 years ago

[PATCH] TurboGears should let you specify a default doctype

Reported by: alastair Owned by: anonymous
Priority: normal Milestone: 1.0.2
Component: View Version: 1.0
Severity: normal Keywords: genshi
Cc:

Description

When using Genshi, you can conveniently change the output format that's generated by the template engine by altering the genshi.outputformat setting. However, the DOCTYPE used in the final output is taken from the template that was passed into Genshi, rather than being selected on the basis of output format, which makes the outputformat option rather less useful than it might otherwise be. This problem might exist with Kid as well, I'm not sure.

The development branch of Genshi has an additional default_doctype option, which we should expose in order to fix this issue.

I've attached a patch that does just that, though we should really consider changing the way the options are exposed to the template engine plug-ins (personally I think it'd make sense just to pass turbogears.config as the engine_options argument…).

Attachments

default_doctype.diff Download (617 bytes) - added by alastair 12 years ago.
Patch turbogears.view.base to pass genshi.default_doctype through.

Change History

Changed 12 years ago by alastair

Patch turbogears.view.base to pass genshi.default_doctype through.

comment:1 Changed 12 years ago by alastair

  • Summary changed from TurboGears should let you specify a default doctype to [PATCH] TurboGears should let you specify a default doctype

Marked this as having a patch.

comment:2 Changed 12 years ago by fredlin

temply fixed in [2795], thanks!

comment:3 Changed 12 years ago by alberto

  • Status changed from new to closed
  • Resolution set to duplicate

comment:4 Changed 11 years ago by Chris Arndt

  • Component changed from Genshi to View
Note: See TracTickets for help on using tickets.