Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1373 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

quickstart.py: newline character in self.name in update.run()

Reported by: anseljh Owned by: anonymous
Priority: normal Milestone: 1.0.3
Component: tg-admin (non-toolbox) Version: 1.0.1
Severity: normal Keywords:
Cc:

Description

I tried to use the tg-admin update command to update my project, and got an odd-looking error message:

"t looks like your project dir "iplctg-svn" is named wrongly. Please rename it to "iplctg

Note the weird placement of the double quotation marks. I suspected a newline character was fouling things up.

I tracked back through quickstart.py to find the error message (line 260), and then back to find where self.name is set (line 243). I added a .strip() to the end, and tried my tg-admin update again, and indeed, the error message looked right:

it looks like your project dir "iplctg-svn" is named wrongly. Please rename it to "iplctg"

So line 243 could be patched as follows:

self.package = turbogears.util.get_package_name().strip()

However, that still leaves open the question of why there was a newline in the first place. Someone should probably check out turbogears.util.get_project_name() and fix that as well.

Change History

comment:1 Changed 12 years ago by alberto

  • Milestone changed from 1.0.2 to 1.0.3

comment:2 Changed 12 years ago by faide

  • Status changed from new to closed
  • Resolution set to fixed

Added a strip() directly on the return value of the turbogears.util.get_project_name()

this way all callers will benefit from it.

It's in r3232 (1.0dev) and r3233 (1.1dev)

Thanks, Florent.

Note: See TracTickets for help on using tickets.