Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1388 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

paginate needs change as SA deprecates SelectResults

Reported by: sanjay Owned by: faide
Priority: normal Milestone: 1.0.3
Component: TurboGears Version: 1.0.2
Severity: normal Keywords:


SqlAlchemy? has deprecated SelectResults?, and suggests to use normal query as it now has all the functionality of SelectResults?.

In TurboGears it has a major impact. The paginate code calculates the number of rows as len(list) if the type of recordset is not SelectResults?. But while using len(list), all the rows are fetched and hence the benefit of pagination is lost.

There are some discussions and suggestions on it here:

 http://groups.google.co.in/group/turbogears/browse_thread/thread/210588e18f9cd09b  http://groups.google.com/group/sqlalchemy/browse_thread/thread/ad6f2f4d1b45d281?hl=en (8th message onwards)

Change History

comment:1 Changed 12 years ago by faide

The #1434 ticket contains a patch that will certainly go in after some tests and that will cope with this "issue".

comment:2 Changed 12 years ago by faide

  • Status changed from new to assigned
  • Owner changed from anonymous to faide

comment:3 Changed 12 years ago by faide

ticket #1434 has been committed so I also close this one.

comment:4 Changed 12 years ago by faide

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.