Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1453 (closed task: fixed)

Opened 10 years ago

Last modified 7 years ago

Create unit tests for identity provider with SQLAlchemy

Reported by: chrisz Owned by: anonymous
Priority: normal Milestone: 1.5
Component: SQLAlchemy Version: 1.0.2
Severity: normal Keywords: SA tests
Cc:

Description

The unit tests in turbogears/identity/tests/test_identity.py test the identity provider only with SQLObject. There should be similar tests for SQLAlchemy too. Maybe problem #1452 would have been detected with such a test.

Change History

comment:1 Changed 9 years ago by faide

  • Milestone changed from 1.1 to 1.1.1

comment:2 Changed 9 years ago by faide

  • Milestone changed from 1.6 to 1.5

comment:3 follow-up: ↓ 4 Changed 8 years ago by Chris Arndt

Also, saprovider.py does not define default identity model classes/tables. These should be ported from soprovider. Since r6715 SqlAlchemyIdentityProvider will load them automatically, when no other classes are defined in the configuration.

comment:4 in reply to: ↑ 3 Changed 7 years ago by chrisz

Replying to Chris Arndt:

Also, saprovider.py does not define default identity model classes/tables. These should be ported from soprovider.

Done in r7205.

comment:5 Changed 7 years ago by chrisz

  • Status changed from new to closed
  • Resolution set to fixed

Separate unit tests for both SA and SO have been implemented in r7206-r7210 now.

TG 1.5 has now 529 unit tests, TG 1.1 has 470, TG 1.0 has 436.

Note: See TracTickets for help on using tickets.