Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1485 (closed defect: fixed)

Opened 11 years ago

Last modified 11 years ago

SA Transaction Rollback Check

Reported by: paj Owned by: paj
Priority: normal Milestone: 1.0.4
Component: SQLAlchemy Version: 1.0.3
Severity: normal Keywords:
Cc:

Description

If you have manually committed/rolledback the transaction inside a controller method, sa_rwt doesn't properly handle this. See this thread  http://tinyurl.com/yq3d47

Looking at the code, there seem to be a few logic problems. I will look at adding a check to see if the transaction is active, before commit/rollback. I'll also create some unit tests for these conditions.

Change History

comment:1 Changed 11 years ago by paj

Ok, I've refactored sa_rwt and added three unit tests. They're in [3423] and [3424]

comment:2 Changed 11 years ago by paj

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.