Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1586 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

[PATCH] testutil.py DbTest: attribute model.soClasses should be used if present

Reported by: ghorvath Owned by: anonymous
Priority: normal Milestone: 1.0.4
Component: TurboGears Version: 1.0.3
Severity: normal Keywords:
Cc: gh@…

Description

I use the the SQLObject soClasses attribute in my model to define the order of class creation and hide specific classes to SQLObject. testutil.DbTest? should also use this attribute if present to create and drop the tables. Patch against TurboGears-1.0.3.2 is attached.

Attachments

testutil_soClasses.diff Download (477 bytes) - added by ghorvath 7 years ago.
New version (the previous one did NOT work)

Change History

Changed 7 years ago by ghorvath

New version (the previous one did NOT work)

comment:1 Changed 7 years ago by ghorvath

  • Cc gh@… added

comment:2 Changed 7 years ago by faide

Pleas use the "diff -u" command to generate your patches as the current patch does not displays correctly in trac and is not using the "good" format.

As per the patch in itself, your intention is to make sure the soClasses attribute is never used at all and we always use the dict attribute to get your classes from the model ?

comment:3 Changed 7 years ago by faide

Sorry! Your patch is in the wrong format _and_ wrong order and I did not register this at first :) you added a control on soClasses!

You have created the patch in the wrong order and it shows like you are trying to remove some code whereas in fact you want to add it.

This is a valid and interesting request.

comment:4 Changed 7 years ago by faide

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r3758

Note: See TracTickets for help on using tickets.