Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1687 (closed task: fixed)

Opened 11 years ago

Last modified 11 years ago

switch TG2 to WebOb

Reported by: max Owned by: max
Priority: normal Milestone: 2.0
Component: TurboGears Version: trunk
Severity: normal Keywords:


Use WebOb? with TG2 in place of WSGIRequest/WSGIResponse (paste).

notes from Alberto: This is turning out to be less of a trivial thing than I thought... :( I couldn't manage to get tests to pass since Pylons needs some patching:

1) In DecoratedController? req.params are immutable (hence no pop or update can be done)

2) In pylons.testutil.SetupCacheGlobal? WSGIRequest and WSGIRepsonse from paste are hardcoded and break when using webob.

After doing the necessary changes in my sandbox I got stuck on tests that blocked (apparently at repl_start_response in pylons.controllers.core while copying headers).

Change History

comment:1 Changed 11 years ago by max

  • Owner changed from anonymous to max
  • Status changed from new to assigned

Pylons completed migration to WebOb

comment:2 Changed 11 years ago by max

  • Status changed from assigned to closed
  • Resolution set to fixed

Can be said as done; though a few quirks remain.

I posted a patch to paste trac ( ticket 226) which closes the AssertionError? about PATH_INFO.

Now I have three failing tests: 304 test plus redirect tests. Redirect tests do not work since the cookie we set (tg_flash) somehow do not get passed on to the request via follow(). It must a bug either in our redirect() code or in paste.fixture follow() impl.

Note: See TracTickets for help on using tickets.