Ticket #1718 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

[Patch] Inherited template params and member_widgets get mixed up

Reported by: chrisz Assigned to: anonymous
Priority: normal Milestone: 1.1
Component: TurboGears Version: 1.0.4.3
Severity: normal Keywords: widgets params
Cc:

Description

Th params and member_widgets are lists with a certain order. However, when mixing in the params and member_widgets from base widgets, TG does not preserve the order and these lists gets mixed up. That's the reason why e.g. in the widgetbrowser the params in the param description tab are in arbitrary order. I have attached patches for 1.0 and 1.1 so that TG preserves the order of these lists.

Attachments

template_params_1_0.patch (2.6 kB) - added by chrisz on 02/12/08 08:07:04.
Keep order of widget params (1.0 branch)
template_params_1_1.patch (4.0 kB) - added by chrisz on 02/12/08 08:15:12.
Keep order of widget params and remove deprecated params (1.1 branch)

Change History

02/12/08 08:07:04 changed by chrisz

  • attachment template_params_1_0.patch added.

Keep order of widget params (1.0 branch)

02/12/08 08:15:12 changed by chrisz

  • attachment template_params_1_1.patch added.

Keep order of widget params and remove deprecated params (1.1 branch)

02/12/08 08:15:48 changed by chrisz

In the 1.1 patch, I have also removed the deprecation warnings for update_data and template_vars. Actually we wanted to remove them in 1.0 already.

03/01/08 06:13:13 changed by chrisz

  • status changed from new to closed.
  • resolution set to fixed.

Since nobody objected, committed to 1.0 and 1.1 in r4184.