Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1718 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

[Patch] Inherited template params and member_widgets get mixed up

Reported by: chrisz Owned by: anonymous
Priority: normal Milestone: 1.5
Component: TurboGears Version: 1.0.4.3
Severity: normal Keywords: widgets params
Cc:

Description

Th params and member_widgets are lists with a certain order. However, when mixing in the params and member_widgets from base widgets, TG does not preserve the order and these lists gets mixed up. That's the reason why e.g. in the widgetbrowser the params in the param description tab are in arbitrary order. I have attached patches for 1.0 and 1.1 so that TG preserves the order of these lists.

Attachments

template_params_1_0.patch Download (2.6 KB) - added by chrisz 10 years ago.
Keep order of widget params (1.0 branch)
template_params_1_1.patch Download (4.0 KB) - added by chrisz 10 years ago.
Keep order of widget params and remove deprecated params (1.1 branch)

Change History

Changed 10 years ago by chrisz

Keep order of widget params (1.0 branch)

Changed 10 years ago by chrisz

Keep order of widget params and remove deprecated params (1.1 branch)

comment:1 Changed 10 years ago by chrisz

In the 1.1 patch, I have also removed the deprecation warnings for update_data and template_vars. Actually we wanted to remove them in 1.0 already.

comment:2 Changed 9 years ago by chrisz

  • Status changed from new to closed
  • Resolution set to fixed

Since nobody objected, committed to 1.0 and 1.1 in r4184.

Note: See TracTickets for help on using tickets.