Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1732 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

FeedController should pass query parameters when redirecting from index() to the default feed controller

Reported by: kikidonk Owned by: anonymous
Priority: normal Milestone: 1.1
Component: TurboGears Version: 1.0.4.3
Severity: normal Keywords:
Cc:

Description

If i call /feed/?foo=bar on the feed controller, it fails if strict parameters are set, but also fail to pass the query arguments to the default feed controller.

in feed/feed.py, line 45 reads:

    def index(self):
        raise cherrypy.HTTPRedirect(turbogears.url("%s" % self.default))
    index = turbogears.expose()(index)

It should be replaced by:

    def index(self, **kwargs):
        raise cherrypy.HTTPRedirect(turbogears.url("%s" % self.default, **kwargs))
    index = turbogears.expose()(index)

So that a call to /feed/?foo=bar is handled as expected by the default feed handler, with the queyr params.

Change History

comment:1 Changed 9 years ago by faide

  • Milestone changed from 1.5 to 1.1

comment:2 Changed 9 years ago by Chris Arndt

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r5291 for the 1.0 and 1.1 branch.

Note: See TracTickets for help on using tickets.