Ticket #1732 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

FeedController should pass query parameters when redirecting from index() to the default feed controller

Reported by: kikidonk Assigned to: anonymous
Priority: normal Milestone: 1.1
Component: TurboGears Version: 1.0.4.3
Severity: normal Keywords:
Cc:

Description

If i call /feed/?foo=bar on the feed controller, it fails if strict parameters are set, but also fail to pass the query arguments to the default feed controller.

in feed/feed.py, line 45 reads: 

    def index(self):
        raise cherrypy.HTTPRedirect(turbogears.url("%s" % self.default))
    index = turbogears.expose()(index)

It should be replaced by: 

    def index(self, **kwargs):
        raise cherrypy.HTTPRedirect(turbogears.url("%s" % self.default, **kwargs))
    index = turbogears.expose()(index)

So that a call to /feed/?foo=bar is handled as expected by the default feed handler, with the queyr params.

Change History

08/24/08 10:27:00 changed by faide

  • milestone changed from 1.5 to 1.1.

08/28/08 14:30:15 changed by Chris Arndt

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r5291 for the 1.0 and 1.1 branch.