Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1761 (closed defect: fixed)

Opened 9 years ago

Last modified 8 years ago

https authentication raises exception if the forward_url has FileField etc.

Reported by: sanjay Owned by: anonymous
Priority: normal Milestone: 1.1.x bugfix
Component: Identity Version: 1.0.4.4
Severity: normal Keywords:
Cc:

Description

Say I have a website where users login through ssl (https). In this case, as of TG 1.0.4.4, I need to set identity.force_external_redirect to True and identity.failure_url to  https://mywebsite/login in app.cfg or prod.cfg.

However, in TG 1.0.4.4 the failure redirection happens through GET but not POST by a parameter named forward_url. This leads to the problem that if an user posts a form having FileField? or voluminous data without logging in, error comes because the forward_url is not able to handle FileField? or big parameters.

If I try the workaround that the user logs in before filling the form itself, then if the user walks away for a while in the middle of filling a form and timeout occurs, the problem props up.

Also, I observed another minor issue. If an user presses login, he is placed at the home page after logging in, but not in the page he was previously in.

Change History

comment:1 Changed 9 years ago by faide

  • Milestone changed from 1.1 to 1.1.1

This is a tricky issue to solve.

comment:2 Changed 9 years ago by faide

  • Milestone changed from 1.6 to 1.5

comment:3 Changed 9 years ago by faide

We should certainly inspect the params and scrub the offenders. This way the method validator would redirect to the form and the user could reenter the scrubbed value.

comment:4 Changed 9 years ago by faide

  • Milestone changed from 1.5 to 1.1

comment:5 Changed 9 years ago by faide

  • Milestone changed from 1.1 to 1.1 maintenance

comment:6 Changed 8 years ago by chrisz

  • Status changed from new to closed
  • Resolution set to fixed

Solved as suggested by faide in r6885.

Note: See TracTickets for help on using tickets.