Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1795 (closed enhancement: fixed)

Opened 10 years ago

Last modified 7 years ago

[PATCH] collect strings marked for i18n in Mako templates

Reported by: wmark Owned by: anonymous
Priority: normal Milestone: 1.1.x bugfix
Component: TurboGears Version: 1.0.4.4
Severity: normal Keywords: needs review
Cc:

Description

The attached patch lets e.g., toolbox search through Mako's template files (ending is .mak) and collect strings marked the gettext way.

Please consider adding extensions for other templates. Such as .html for Genshi.

Attachments

trubogears-1.x_mako_i18n_collect.patch Download (770 bytes) - added by wmark 10 years ago.

Change History

Changed 10 years ago by wmark

comment:1 Changed 10 years ago by Chris Arndt

  • Milestone changed from 1.0.x bugfix to 1.1

comment:2 Changed 10 years ago by Chris Arndt

See also #1733.

comment:3 Changed 9 years ago by faide

  • Milestone changed from 1.5 to 1.1

comment:4 Changed 9 years ago by Chris Arndt

  • Keywords needs review added

comment:5 Changed 9 years ago by faide

Could you confirm that just adding the .mak extension in the extension list (1.1 branch) would work as expected with Mako? I don't have Mako on 1.1 right now...

comment:6 Changed 9 years ago by wmark

I do confirm.

comment:7 Changed 9 years ago by faide

applied to r5814.

This also needs to be applied (mako support) to the command line tools.

Leaving open for the moment. I would like some mako user to try and use the command line version to see what needs to be done.

comment:8 Changed 9 years ago by chrisz

Why do we actually have two different ways (command line and toolbox) of collecting strings? I understand that we want tow different UIs, but why do they use different code under the hood (code that works slightly different and contains different flaws)? Shouldn't we try to merge them (or use Babel, as in TG2)?

comment:9 Changed 8 years ago by Chris Arndt

See #2040 for a i18n package refactoring task ticket.

comment:10 Changed 8 years ago by Chris Arndt

  • Milestone changed from 1.1 to 1.0.x bugfix

Moving to 1.1.x bugfix release in preparation for 1.1rc1 release.

comment:11 Changed 8 years ago by Chris Arndt

  • Milestone changed from 1.0.x bugfix to 1.1.x bugfix

comment:12 Changed 7 years ago by chrisz

  • Status changed from new to closed
  • Resolution set to fixed

I consider this as solved modulo #2040.

Note: See TracTickets for help on using tickets.