Ticket #1795 (closed enhancement: fixed)
[PATCH] collect strings marked for i18n in Mako templates
| Reported by: | wmark | Owned by: | anonymous |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.1.x bugfix |
| Component: | TurboGears | Version: | 1.0.4.4 |
| Severity: | normal | Keywords: | needs review |
| Cc: |
Description
The attached patch lets e.g., toolbox search through Mako's template files (ending is .mak) and collect strings marked the gettext way.
Please consider adding extensions for other templates. Such as .html for Genshi.
Attachments
-
trubogears-1.x_mako_i18n_collect.patch
(770 bytes) -
added by wmark 9 years ago.
Change History
comment:5 Changed 9 years ago by faide
Could you confirm that just adding the .mak extension in the extension list (1.1 branch) would work as expected with Mako? I don't have Mako on 1.1 right now...
comment:7 Changed 9 years ago by faide
applied to r5814.
This also needs to be applied (mako support) to the command line tools.
Leaving open for the moment. I would like some mako user to try and use the command line version to see what needs to be done.
comment:8 Changed 8 years ago by chrisz
Why do we actually have two different ways (command line and toolbox) of collecting strings? I understand that we want tow different UIs, but why do they use different code under the hood (code that works slightly different and contains different flaws)? Shouldn't we try to merge them (or use Babel, as in TG2)?
comment:10 Changed 8 years ago by Chris Arndt
- Milestone changed from 1.1 to 1.0.x bugfix
Moving to 1.1.x bugfix release in preparation for 1.1rc1 release.
comment:12 Changed 6 years ago by chrisz
- Status changed from new to closed
- Resolution set to fixed
I consider this as solved modulo #2040.
