Ticket #1891 (new defect)

Opened 3 months ago

Last modified 1 month ago

[PATCH]: Change testutil to drop DROP...CASCADE when dropping tables

Reported by: mw44118 Assigned to: kskuhlman
Priority: normal Milestone: 1.1 beta 2
Component: TurboGears Version: 1.0.4.4
Severity: minor Keywords: needs tests
Cc:

Description

I've got a data model where two tables refer to each other. testutil bombs because when it drops the tables, postgres fusses that it needs the CASCADE keyword.

So this insignificant patch adds cascade=True.

Attachments

my_patch.diff (0.5 kB) - added by mw44118 on 07/09/08 11:19:22.

Change History

07/09/08 11:19:22 changed by mw44118

  • attachment my_patch.diff added.

08/21/08 12:38:23 changed by kskuhlman

  • owner changed from anonymous to kskuhlman.

08/21/08 13:24:26 changed by Chris Arndt

Maybe there should also be a source code comment added that explains why this parameter is present.

08/21/08 13:26:27 changed by Chris Arndt

Also a test is missing that demonstrates that this indeed correctly drops cross-referencing tables.

08/21/08 21:49:19 changed by kskuhlman

  • severity changed from normal to minor.
  • milestone set to 1.5.

Committed in r5196 for 1.1 & 1.5. Leaving ticket open due to Chris' concerns re: specific test.

08/24/08 10:27:00 changed by faide

  • milestone changed from 1.5 to 1.1.

09/10/08 16:49:02 changed by Chris Arndt

  • keywords set to needs tests.

09/10/08 16:49:10 changed by Chris Arndt

  • milestone changed from 1.1 to 1.1 beta 2.