Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #192 (closed defect: worksforme)

Opened 14 years ago

Last modified 12 years ago

bad script tag in turbogears/widgets/__init__.py's JSLink()

Reported by: anders@… Owned by: anonymous
Priority: low Milestone: 0.9
Component: TG Widgets Version:
Severity: minor Keywords:
Cc:

Description

just browsing through the source for widgets to see how it was coming and i noticed a small issue in the JSLink() function in turbogears/widgets/init.py.

on line 175 (at the time of writing), is:

template = '<script type="text/javascript" src="$link"/>'

which, unfortunately won't work in many browsers. instead it should be:

template = '<script type="text/javascript" src="$link"></script>'

Change History

comment:1 Changed 14 years ago by SuperJared <jared.kuolt@…>

As far as I know Kid will convert it to the second style when serializing the output back to HTML (unless you've set it for XHTML).

comment:2 Changed 13 years ago by anonymous

  • Milestone set to 0.9

comment:3 Changed 13 years ago by KarlGuertin

  • Status changed from new to closed
  • Resolution set to worksforme

This was fixed in kid and is working in r522. worksforme

Note: See TracTickets for help on using tickets.