Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1921 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

Flash Message modifications

Reported by: cd34 Owned by: anonymous
Priority: normal Milestone:
Component: Installation Version: trunk
Severity: normal Keywords:
Cc:

Description

Flash messages appear to always output the green bar and checkbox, regardless of the status that is set. Granted, it's a small css and template change, but, the current settings are a bit confusing when you use flash to present an error and are presented with a green checkmark and a green bar which usually signifies an 'ok' response.

While I've not uploaded any graphics, the following diff's at least give some basic functionality to the flash message by supporting status_ok, status_warning and status_alert and should guide someone a little further in making template and css changes. Changes are to the .css file and master.html. Diff's attached.

Attachments

master.html.diff Download (781 bytes) - added by cd34 11 years ago.
css.diff Download (1.0 KB) - added by cd34 11 years ago.
modified style.css diff to handle flash messages as it appears the original web designer intended

Change History

Changed 11 years ago by cd34

comment:1 Changed 11 years ago by cd34

after digging a little further into the CSS, I see how the original html author intended the function to be used. I've submitted some minor css to utilize the included graphics and cleaned up the CSS a bit.

comment:2 Changed 11 years ago by cd34

also, in sidebar there is a color of #fffe1 which is invalid. I believe the color was originally intended to be #ffffe1 which I've submitted with the updated diff.

Changed 11 years ago by cd34

modified style.css diff to handle flash messages as it appears the original web designer intended

comment:3 Changed 11 years ago by mramm

  • Milestone set to 1.9.7a4

comment:4 Changed 11 years ago by mramm

Patches applied, I have not tested on a variety of browsers though...

comment:5 Changed 11 years ago by mramm

  • Status changed from new to closed
  • Resolution set to fixed

comment:6 Changed 10 years ago by anonymous

  • Milestone 1.9.7a4 deleted

Milestone 1.9.7a4 deleted

Note: See TracTickets for help on using tickets.