Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1946 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

url() not working with multiple root controllers

Reported by: kskuhlman Owned by: kskuhlman
Priority: high Milestone: 1.5
Component: TurboGears Version:
Severity: blocker Keywords: wsgi webpath
Cc:

Description

chrisz added 3 new tests for #1919 that show this issue. Those tests pass in the 1.1 branch, but fail in 1.5 because I removed check_app_root in that branch.

I need to figure out what the relationship is between SCRIPT_NAME, server.webpath, and VirtualPathFilter. I've seen references that hint that VirtualPathFilter shouldn't be necessary under CP3, but I don't know what the replacement should be.

Perhaps check_app_root just needs to be re-introduced, but I keep wondering if there isn't a solution that leaves the code simpler.

Change History

comment:1 Changed 3 years ago by kskuhlman

  • Status changed from new to assigned
  • Severity changed from normal to blocker

comment:2 Changed 3 years ago by faide

  • Milestone changed from 1.6 to 1.5

comment:3 Changed 3 years ago by kskuhlman

  • Status changed from assigned to closed
  • Resolution set to fixed

This one had me stumped for quite a while; wrote a bunch of code that almost worked, but was over-designed. I'm almost ashamed to admit that the ultimate solution was just a few lines of code. :-)

Fixed in r5462

Note: See TracTickets for help on using tickets.