Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1948 (closed enhancement: fixed)

Opened 11 years ago

Last modified 11 years ago

Reconsider deprecation of config.get

Reported by: kskuhlman Owned by: kskuhlman
Priority: high Milestone: 1.5
Component: TurboGears Version: 1.5 HEAD
Severity: normal Keywords:
Cc:

Description

turbogears.config.get is currently deprecated in the 1.5 branch in favor of config.server.get (which is simply a pointer to CherryPy 3's config), and request.config.get. However, the need to train people to use request.config when inside of a request increases the barrier to 1.5's adoption.

We should consider making turbogears.config.get request-aware & removing the deprecation. This would also reduce the number of trivial diffs between the 1.1 & 1.5 branches.

Change History

comment:1 Changed 11 years ago by Chris Arndt

Yes, I think we need a compatibility layer in TG 1.5 for accessing config settings like in TG 1.0.x. This would greatly reduce the effort for porting apps from TG 1.0.x to 1.5.

comment:2 Changed 11 years ago by faide

  • Milestone changed from 1.6 to 1.5

comment:3 Changed 11 years ago by kskuhlman

  • Status changed from new to closed
  • Version set to 1.5 HEAD
  • Resolution set to fixed

config.get is now request-aware, and no longer deprecated. This simplifies 1.5's config api significantly. Note that it was always 1.0/1.1 compatible, just deprecated. Fixed in r5488.

comment:4 Changed 11 years ago by Chris Arndt

Awesome, Ken. You rock!

Note: See TracTickets for help on using tickets.