Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1964 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Label Widget does not render attrs

Reported by: ghorvath Owned by: faide
Priority: normal Milestone: 1.0.x bugfix
Component: TG Widgets Version: 1.0.4.4
Severity: normal Keywords:
Cc:

Description

The Label widget does not render the attrs parameter, because it is missing in the template. Attached a patch against 1.0 r5251

Attachments

attrs_in_label.diff Download (371 bytes) - added by ghorvath 3 years ago.
Patch missing attrs in Label template

Change History

Changed 3 years ago by ghorvath

Patch missing attrs in Label template

comment:1 Changed 3 years ago by Chris Arndt

  • Owner changed from anonymous to faide

Applied in r5261 for the 1.1 branch.

Florent, should this be applied to the 1.0 branch as well? I think we need a solid guideline now that 1.0.6 is out on which kind of fixes should still go into 1.0.

comment:2 Changed 3 years ago by chrisz

My opinion is that simple and harmless fixes like this one should be backported for a while as long as 1.1 is not yet released and reasonably stable.

comment:3 Changed 3 years ago by Chris Arndt

  • Status changed from new to closed
  • Resolution set to fixed

Ok, applied to 1.0 branch in r5270.

Note: See TracTickets for help on using tickets.