Ticket #1967 (closed defect: fixed)
`test_config.test_windows_filenames` fails in 1.1 branch
|Reported by:||Chris Arndt||Owned by:||anonymous|
test_config.test_windows_filenames fails in 1.1 branch on this line. The same test code passes in the 1.0 branch.
The way this test module is written is totally weird and I don't understand why it ever worked:
- The tests have no docstrings so you have to guess what they test for
- The tests influence each other by changing the global configuration and not unsetting the changes
- A test changes the pkg_resources.resource_filename function midway through the execution of the module but this is only undone by the teardown_module function at the end of the tests.
- The behaviour of windows_filename function changes with the number of times it has been called and thus make the test results dependent on the order of the statements in the module and the order of the execution of the tests.
I think this test module needs to be seriously refactored. I attach a patch with a first go at this. Unfortunately this doesn't fix the failing test, but since I have no idea what it is supposed to test, I don't know how to do this.