Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #1976 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

1.9.7a4 Install Missing Dependencies for Testing

Reported by: dlatornell Owned by: anonymous
Priority: normal Milestone:
Component: Installation Version: trunk
Severity: normal Keywords:
Cc:

Description

To run the as-installed tests on a 1.9.7a4 quickstart the WebTest and BeautifulSoup packages are required.

webtest is imported at source:projects/tg.devtools/trunk/devtools/templates/turbogears/+package+/tests/__init__.py_tmpl@5091#16

BeautifulSoup is required to pass the 2nd (checking for links) test in source:projects/tg.devtools/trunk/devtools/templates/turbogears/+package+/tests/functional/test_root.py_tmpl@5091#16

Attachments

test_dependencies.patch Download (1.9 KB) - added by jorge.vargas 11 years ago.
patch to fix the dependencies issue.

Change History

comment:1 follow-up: ↓ 2 Changed 11 years ago by dlatornell

A couple of thoughts on the resolution of this:

If WebTest is going to replace paste.fixture in 2.0, then WebTest obviously needs to be included in the package index for 1.9.7a4 and beyond.

Inclusion of BeautifulSoup is less clear to me. Useful function tests of the stack can be done without it, so perhaps we should document it as a tool that can be used, but not make the quickstart app tests depend on it.

comment:2 in reply to: ↑ 1 Changed 11 years ago by dlatornell

Replying to dlatornell:

Inclusion of BeautifulSoup is less clear to me. Useful functional tests of the stack can be done without it, so perhaps we should document it as a tool that can be used, but not make the quickstart app tests depend on it.

Okay, BeautifulSoup rocks! It provides a lot more power for testing page results than simple assert 'foo' in response.body statements.

So, the only question that remains is: Do WebTest and BeautifulSoup get included in the package index for 1.9.7a5 and onward? I think they should.

comment:3 Changed 11 years ago by mramm

I'm all for it. All we need to do is add the eggs to the package index source at /site_resources/tg2_index/ and they will be added to the index when we regenerate for the next release.

To force them to be installed, we can add them to the setup.py of tg.devtools. This avoids making them requirements of tg2 proper, but gets them into everybody's toolkit.

comment:4 Changed 11 years ago by jorge.vargas

I found this issue in parallel by testing the current index.

I believe the correct solution is to include WebTest?, (it is needed for tg test stack), and leave BeautifulSoup? out, as it is a recommendation not a requirement, for that I have added a comment pretty much in the same way WebTest? does it. I wrote a patch to fix this, I'll attach it here too.

I outlined my comments here.  http://groups.google.com/group/turbogears-trunk/msg/d277b68bca25ee4a

Changed 11 years ago by jorge.vargas

patch to fix the dependencies issue.

comment:5 Changed 10 years ago by mramm

  • Status changed from new to closed
  • Resolution set to fixed

comment:6 Changed 10 years ago by anonymous

  • Milestone 1.9.7b1 deleted

Milestone 1.9.7b1 deleted

Note: See TracTickets for help on using tickets.