Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2002 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

[PATCH] setup_genshi_renderer() fix

Reported by: TimurIzhbulatov Owned by: faide
Priority: normal Milestone: 2.0b1
Component: TurboGears Version: trunk
Severity: normal Keywords: genshi i18n translator filter template loader
Cc:

Description

A patch to fix the setup_genshi_renderer() method which is broken because it defines a template loader callback but doesn't actually pass it to the loader, and the callback function itself also contains a bug.

Attachments

setup-genshi-fix.diff Download (757 bytes) - added by TimurIzhbulatov 11 years ago.

Change History

Changed 11 years ago by TimurIzhbulatov

comment:1 Changed 10 years ago by TimurIzhbulatov

  • Milestone changed from 1.9.7a5 to 2.0b1

comment:2 Changed 10 years ago by TimurIzhbulatov

  • Status changed from new to closed
  • Resolution set to fixed

comment:3 Changed 10 years ago by faide

  • Status changed from closed to reopened
  • Resolution fixed deleted

Is it possible to write a test suite (success, failure) for this to make sure we don't get regressions?

I know this is more work, but this is also the only way to ensure quality in the medium to long run.

Also please give info about the revision # when closing a ticket so the administrative tasks afterwards are eased.

comment:4 Changed 10 years ago by TimurIzhbulatov

Sorry for that. I'll try to come up with the test later this week.

It was fixed by [5522:5523].

comment:5 Changed 10 years ago by mramm

  • Status changed from reopened to closed
  • Resolution set to fixed

There is actually already a test that covers the genshi renderer already, so marking this as fixed.

Note: See TracTickets for help on using tickets.