Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2023 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

[PATCH] Allow datagrid to set name at display time

Reported by: mw44118 Owned by: faide
Priority: normal Milestone: 1.0.x bugfix
Component: TurboGears Version: 1.0.7
Severity: normal Keywords: DataGrid display
Cc:

Description

the datagrid widget uses the name parameter to set html ID of the widget. So, if I want to render the same datagrid instance twice on the same page, I get an html validation error, because I have two tables with the same id.

It is already possible to pass in name='blah' to the display method, and the docs say that this should be used to set the name parameter, but actually, the value passed in to display is overwritten by the self.name value.

So, this patch fixes that issue.

Attachments

my_patch.diff Download (583 bytes) - added by mw44118 8 years ago.
Resubmitting same patch after running svn diff on my whole checkout, not just one file

Change History

Changed 8 years ago by mw44118

Resubmitting same patch after running svn diff on my whole checkout, not just one file

comment:1 Changed 8 years ago by chrisz

  • Status changed from new to closed
  • Resolution set to fixed

Good catch, patched in r5858. Note that this still doesn't work with forms fields, but there it doesn't make sense anyway.

Note: See TracTickets for help on using tickets.