Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2108 (closed enhancement: fixed)

Opened 11 years ago

Last modified 11 years ago

[PATCH] Add scheduler functionality to Turbogears 2

Reported by: vinces1979 Owned by: faide
Priority: normal Milestone: 2.0
Component: TurboGears Version: trunk
Severity: normal Keywords:
Cc:

Description

I needed to use the scheduler from TG1 in TG2, so I put together the same functionality using the scheduler.py in TG1 and calling start/stop during the configuration init.

I added two config variables for the scheduler

I attached the scheduler diff and my test example

Attachments

example_scheduler_setup.diff Download (1.4 KB) - added by vinces1979 11 years ago.
tg2-scheduler.diff Download (24.1 KB) - added by vinces1979 11 years ago.

Change History

Changed 11 years ago by vinces1979

Changed 11 years ago by vinces1979

comment:1 Changed 11 years ago by vinces1979

  • Milestone changed from 2.0 to 2.0b1

comment:2 Changed 11 years ago by vinces1979

  • Summary changed from Add scheduler functionality to Turbogears 2 to [PATCH] Add scheduler functionality to Turbogears 2

comment:3 Changed 11 years ago by mramm

  • Milestone changed from 2.0b1 to 2.0b2

comment:4 Changed 11 years ago by jorge.vargas

Hi, I think the scheduler is something that should be left out of TG2 core, ideally it should because it's own package with a config directive to enable it.

comment:5 follow-up: ↓ 6 Changed 11 years ago by vinces1979

Does TG2 have similar functionality to: 1's turbogears.startup.call_on_startup, which could be hooked into to call the scheduler?

comment:6 in reply to: ↑ 5 Changed 11 years ago by vinces1979

Replying to vinces1979:

Does TG2 have similar functionality to: 1's turbogears.startup.call_on_startup, which could be hooked into to call the scheduler?

I wasn't able to find call_on_startup so I created a patch to create base_config.call_on_startup/shutdown, #2117

comment:7 Changed 11 years ago by vinces1979

I moved the scheduler code into a TG widget, which works fine with PATCH #2117

 http://pypi.python.org/pypi/TGScheduler  http://tgscheduler.googlecode.com/

comment:8 Changed 11 years ago by mramm

So, it's OK to mark this as closed if we implement #2117 and document how to use the new TGScheduler?

Sounds like a good plan to me. Any objections?

comment:9 Changed 11 years ago by mramm

  • Priority changed from normal to lowest
  • Milestone changed from 2.0b2 to 2.0

comment:10 Changed 11 years ago by mramm

  • Priority changed from lowest to normal

comment:11 follow-up: ↓ 12 Changed 11 years ago by jorge.vargas

+1 on closing

vinces1979, could you please add me (jorge.vargas@…) as co-maintainer of the gcode project? I don't plan to commit anything in the near future but it's always nice to have more people involved.

Also I think you should release it as 1.0 as this is proven code, at least 2-3years, just under a new namespace.

comment:12 in reply to: ↑ 11 Changed 11 years ago by vinces1979

Replying to jorge.vargas:

+1 on closing

vinces1979, could you please add me (jorge.vargas@…) as co-maintainer of the gcode project? I don't plan to commit anything in the near future but it's always nice to have more people involved.

Also I think you should release it as 1.0 as this is proven code, at least 2-3years, just under a new namespace.

DONE: Jorge you are added as an admin on the gcode project and I updated the release to 1.0

comment:13 follow-up: ↓ 14 Changed 11 years ago by faide

just in case add mark and florent...

and also add co-maintainers in the related pypi account so that anyone of us can release the thing if need be

comment:14 in reply to: ↑ 13 ; follow-up: ↓ 15 Changed 11 years ago by vinces1979

Replying to faide:

just in case add mark and florent...

and also add co-maintainers in the related pypi account so that anyone of us can release the thing if need be

not a problem, but I would need their gcode and cheeseshop usernames, you send them via email or irc as well

comment:15 in reply to: ↑ 14 ; follow-up: ↓ 16 Changed 11 years ago by jorge.vargas

  • Status changed from new to closed
  • Resolution set to fixed

ok closing as fixed, as we are going to have a release tomorrow.

Replying to vinces1979:

Replying to faide:

just in case add mark and florent...

and also add co-maintainers in the related pypi account so that anyone of us can release the thing if need be

not a problem, but I would need their gcode and cheeseshop usernames, you send them via email or irc as well

yea I though about that but I didn't wanted to volunteer you guys for the job if you wheren't up to it.

As for the usernames, they can be picked up here  http://code.google.com/p/tgtools/

comment:16 in reply to: ↑ 15 Changed 11 years ago by vinces1979

Replying to jorge.vargas:

ok closing as fixed, as we are going to have a release tomorrow.

Replying to vinces1979:

Replying to faide:

just in case add mark and florent...

and also add co-maintainers in the related pypi account so that anyone of us can release the thing if need be

not a problem, but I would need their gcode and cheeseshop usernames, you send them via email or irc as well

yea I though about that but I didn't wanted to volunteer you guys for the job if you wheren't up to it.

As for the usernames, they can be picked up here  http://code.google.com/p/tgtools/

I added mark and florent to the gcode project for now, if you guys want access to the cheeseshop package let me know

Note: See TracTickets for help on using tickets.