Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2109 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Missing hashlib on python2.4

Reported by: lszyba1 Owned by: jorge.vargas
Priority: normal Milestone: 2.0b3
Component: TurboGears Version: trunk
Severity: normal Keywords:
Cc:

Description (last modified by jorge.vargas) (diff)

When installing tg2 on a python2.4 the hashlib package is missing. It is in python2.5 as one of the core libraries but not in python2.4.

Is it possible to add a requirement for hashlib? I'm not sure what would be the setup.py statement that would do that.

 File "/usr/local/turbogears/myapp/myapp/model/auth.py", line 1, in ?
   from hashlib import sha1
ImportError: No module named hashlib

Thanks, Lucas

Attachments

haslib_error_5977.diff Download (850 bytes) - added by lszyba1 10 years ago.
patch for auth.py

Change History

comment:1 Changed 10 years ago by mramm

  • Milestone changed from 2.0b1 to 2.0b2

comment:2 Changed 10 years ago by jorge.vargas

  • Description modified (diff)

We should either

a- make a conditional import at auth.py b- document the issue.

comment:3 Changed 10 years ago by mramm

Another option is to document installing hashlib and pysqlite2 for 2.4 users. Along with better error messages, I actually think this is good enough.

comment:4 Changed 10 years ago by lszyba1

that sounds good to me, as long as error says "hashlib not installed, please install it. Example: easy_install hashlib"

Changed 10 years ago by lszyba1

patch for auth.py

comment:5 Changed 10 years ago by lszyba1

attached is a patch with the error warning. discussed here. please commit in.

comment:6 Changed 10 years ago by jorge.vargas

  • Owner changed from faide to jorge.vargas

I'll take care of this and the pysqlite with a similar approach.

comment:7 Changed 10 years ago by jorge.vargas

  • Status changed from new to closed
  • Resolution set to fixed

commited in r6091, please test trunk with 2.4, as for pysqlite see #1850

comment:8 Changed 10 years ago by mramm

  • Milestone changed from 2.0b2 to 2.0b3

comment:9 Changed 10 years ago by jorge.vargas

if you are interested in this issue #2133 is also interesting.

Note: See TracTickets for help on using tickets.