Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2162 (closed enhancement: fixed)

Opened 9 years ago

Last modified 8 years ago

[PATCH] Remove unnecessary code from catwalk (sqlobject delete cascades automatically)

Reported by: fetchinson Owned by: Chris Arndt
Priority: low Milestone: 1.1
Component: TurboGears Version: 1.1 HEAD
Severity: minor Keywords:
Cc:

Description

In older versions of sqlobject, < 0.7.2, relatedjoined items were not removed automatically, but in newer versions they are. See this correspondence and Oleg's comment about fixing it:

 http://www.mail-archive.com/sqlobject-discuss@lists.sourceforge.net/msg02932.html

In catwalk, when removing an object, this was not assumed and it iterated over items in the intermediate table. Since in sqlobject this has been fixed it is no longer necessary. All previous tests pass and no documentation change is necessary.

Attachments

catwalk.patch Download (1.1 KB) - added by fetchinson 9 years ago.
Patch to remove some unnecessary catwalk code

Change History

Changed 9 years ago by fetchinson

Patch to remove some unnecessary catwalk code

comment:1 Changed 8 years ago by Chris Arndt

  • Status changed from new to assigned
  • Owner changed from faide to Chris Arndt
  • Summary changed from Removed unnecessary code from catwalk (sqlobject delete automatically) to [PATCH] Remove unnecessary code from catwalk (sqlobject delete cascades automatically)

comment:2 Changed 8 years ago by Chris Arndt

  • Status changed from assigned to closed
  • Resolution set to fixed

Applied in r6667. Thanks!

Note: See TracTickets for help on using tickets.