Ticket #2250 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

[PATCH] Repoze.what cannot handle non-ascii error messages

Reported by: chrisz Assigned to: Gustavo
Priority: high Milestone: 2.0rc1
Component: TurboGears Version: 2.0b6
Severity: major Keywords: repoze.what
Cc:

Description

Steps to reproduce the problem:

  • Quickstart a TG2 project with authorization
  • Setup the database and run the project with --reload
  • Surf to http://localhost:8080/manage_permission_only
  • You get an error message "Only for managers"
  • In the require decorator of the controllers.root.manage_permission_only method, set msg=l_(u'Nur für Mänätscher'), i.e. put some non-ascii chars in the error message (make sure you have an encoding hint at the top of the file).
  • Surf to http://localhost:8080/manage_permission_only
  • You get an UnicodeEncodeError

Cause: The error message cannot be converted to unicode

Solution: In repoze.what.predicates, add the following method to the PredicateError class: 

class PredicateError(Exception):

    def __unicode__(self):
        return unicode(self.message)

Change History

(in reply to: ↑ description ) 03/02/09 10:09:45 changed by Gustavo

  • owner set to Gustavo.
  • status changed from new to assigned.

We were already aware of this issue, but it's a bug in Python itself (in its logging package). It's fixed in Python 2.6.

I'll check this to see if it's a valid workaround. Thanks.

03/02/09 10:29:46 changed by Gustavo

  • status changed from assigned to closed.
  • resolution set to invalid.

Unfortunately, Exception.message is available as of Py 2.5 (although deprecated in Py 2.6), so Py 2.4 users will get AttributeError exceptions even if the message contains ASCII chars only. :(

Thanks anyway! ;-)

(follow-up: ↓ 4 ) 03/02/09 11:16:09 changed by chrisz

  • status changed from closed to reopened.
  • resolution deleted.

I'm reopening this because I consider it very important - my users really want localized error messages.

So how about the following patch that should work with Py 2.4-2.6 (it does nothing with Py 2.6): 

class PredicateError(Exception):
    if not hasattr(Exception, '__unicode__'):
        def __unicode__(self):
            return unicode(self.args and self.args[0] or '')

(in reply to: ↑ 3 ; follow-up: ↓ 5 ) 03/02/09 11:45:37 changed by Gustavo

Replying to chrisz:

I'm reopening this because I consider it very important - my users really want localized error messages.

Localized error messages are supported, the only problem is when they are logged in Py < 2.6.

So how about the following patch that should work with Py 2.4-2.6 (it does nothing with Py 2.6): {{{ class PredicateError?(Exception): if not hasattr(Exception, 'unicode'): def unicode(self): return unicode(self.args and self.args[0] or ) }}}

Yes, it does seem to work. I'll try to verify it and apply it today.

(in reply to: ↑ 4 ) 03/02/09 13:14:28 changed by chrisz

Replying to Gustavo:

Localized error messages are supported, the only problem is when they are logged in Py < 2.6.

But by default they *are* logged in the TG2 development environment.

And besides the logging, there is also another problem with the ActionProtector class in repoze.what.pylons which contains the following code 

        except NotAuthorizedError, e:
            reason = unicode(e)

Without the patch, this fails for Py < 2.6.

03/02/09 15:57:03 changed by Gustavo

  • status changed from reopened to closed.
  • resolution set to fixed.

Thank you very much for your help, Christoph!

It worked and the fix is now on repoze.what 1.0.5.

Enjoy! ;-)

03/02/09 16:41:53 changed by chrisz

Thanks for the quick fix :) This is why I like open source.