Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2308 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Config setting toscawidgets.on vs tools.toscawidgets.on

Reported by: kskuhlman Owned by: kskuhlman
Priority: low Milestone: 1.5
Component: TurboGears Version: 1.5 HEAD
Severity: minor Keywords: ToscaWidgets


In TG 1.5, toscawidgets has been converted to a tool, so it is enabled with tools.toscawidgets.on = True. However, ToscaWidgets itself checks for simply toscawidgets.on.

We need to either figure out how to turn the tool on using the setting that ToscaWidgets expects, or ask Alberto et al. to change the config value that TW checks.

There are 4 TG integration tests failing due to this config value discrepancy.

Change History

comment:1 Changed 10 years ago by kskuhlman

  • Status changed from new to assigned
  • Priority changed from normal to low
  • Severity changed from normal to minor

Fixed test failures & bridged config difference in r6556. Using the old config value will issue a deprecation message.

Leaving ticket open for now, until we determine if ToscaWidgets should be changed.

comment:2 Changed 9 years ago by chrisz

  • Status changed from assigned to closed
  • Resolution set to fixed

The same problem applies to the visit subsystem that has also been converted to a tool. In both cases I think it's better to keep the old simple config settings without the tools prefix and consider the fact that these are implemented as CherryPy tools an implementation detail that can be changed. The whole idea of the TG 1.5 branch is to stay as compatible as possible, including config settings.

The corresponding config settings for the CherryPy tools can be created automatically behind the scenes. This is how I implemented it in r7108.

Note: See TracTickets for help on using tickets.