Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2310 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

[PATCH] TG2 currently does not work with jinja2

Reported by: mbailey Owned by:
Priority: normal Milestone: 2.0final
Component: TurboGears Version: trunk
Severity: normal Keywords:
Cc:

Description

modified setup function to import the new module namespace as well as use the new Environment() argument differences. Also modified the jinja tests to pass with jinja2.

Attachments

jinja2.diff Download (1.7 KB) - added by mbailey 10 years ago.
Diff against turbogears trunk as of 4/18/2009 2:10am Eastern

Change History

Changed 10 years ago by mbailey

Diff against turbogears trunk as of 4/18/2009 2:10am Eastern

comment:1 Changed 10 years ago by jorge.vargas

  • Milestone set to 2.0

patch seems good +1, I'll like someone that uses jinja to confirm it before applying.

comment:2 Changed 10 years ago by mbailey

Any movement on this?

comment:3 follow-up: ↓ 5 Changed 10 years ago by faide

I asked for some feedback on the ML and no-one answered... :( Would you like to become a maintainer of the Jinja support in tg2? If so I would be glad to get you on-board and to work with you in our rendering quest (template lookup, dotted/non-dotted, speed?...)

comment:4 Changed 10 years ago by mramm

Yea, feel free to apply the patch. I'll do it if I have time tomorrow, but we definitely should get this in before 2.0 final.

comment:5 in reply to: ↑ 3 Changed 10 years ago by mbailey

Replying to faide:

I asked for some feedback on the ML and no-one answered... :( Would you like to become a maintainer of the Jinja support in tg2? If so I would be glad to get you on-board and to work with you in our rendering quest (template lookup, dotted/non-dotted, speed?...)

Sorry i don't have time to be a responsible maintainer. However, i am working on a project(hence the lack of time) which uses TG2 and Jinja2, so i run into any problems I will gladly submit patches, such as I did here.

comment:6 Changed 10 years ago by percious

  • Status changed from new to closed
  • Version changed from 2.0b7 to 2.1
  • Resolution set to fixed
  • Milestone changed from 2.0 to 2.1a1

comment:7 Changed 10 years ago by jorge.vargas

  • Version changed from 2.1 to trunk
  • Milestone changed from 2.1a1 to 2.0final

This is important so I backported it to 2.0 in r6572

Note: See TracTickets for help on using tickets.