Ticket Navigation

Ticket #2313 (closed defect: fixed)

Opened 1 year ago

Last modified 7 months ago

To reproduce the problem, quickstart an application, add the following at the top of controllers/root,

from tg import validate
from formencode import validators

and change the index method of the root controller like this:

    @expose('foo.templates.index')
    @validate(validators=dict(nr=validators.Int()))
    def index(self, nr=None):
        ...

Now run the application and surf to http://localhost:8080/index/1.

The validator should pass, but I'm getting this:

TypeError: index() got multiple values for keyword argument 'nr'

See also this thread in the tg-trunk mailing list.

fix_r6567_t2313.diff (1.3 kB) - added by anthonyt on 06/15/09 22:10:30.: fix off by one error

Seems to have been fixed in percious' dispatch refact branch.

fix off by one error

There's a bug in the fix for this ticket in the 2.0 branch (revision 6567 in svn).

It's an off by one error, where the keyword arguments are placed into the args list at the wrong indexes.

When a decorated action expects arguments (self, foo, bar), it might end up getting arguments (foo, bar) instead.

I've attached a patch that should fix the problem.

It's not as good a solution as the one in the 2.1 branch, but it fixes the bug without any large refactoring.

summary changed from Validate decorator does not work with url args to [PATCH] Validate decorator does not work with url args.

The refractoring was due to several other issues. The main one was to make controllers.py into a package for easier maintenance.

Current plans are not to release 2.0.4 and simply release 2.1 so I'm tempted to mark this as a workfix.