Ticket #2344 (closed defect: duplicate)

Opened 9 months ago

Last modified 4 months ago

formencode 1.2.2 sends 'domain' as a kwarg to trans

Reported by: skyleach Assigned to:
Priority: normal Milestone: 2.1
Component: TurboGears Version: 2.0.1
Severity: minor Keywords:
Cc:

Description

formencode (specifically version 1.2.2) has started sending a keyword argument list to implementation-specific translation methods.

I appologize for not knowing enough detail here to have specifically tracked down why 'domain' is being passed as a keyword, but as a temporary fix that is backwards-compatible I suggest making pylons_formencode_gettext accept **kwargs.

stack trace and patch file for tg 2.0.1 included.

Attachments

stacktrace_tg2.0.1_formencode_1.2.2.txt (4.8 kB) - added by skyleach on 06/30/09 17:01:11.
stack trace of exception.
tg_2.0.1_controllers.py.patch (0.8 kB) - added by skyleach on 06/30/09 17:06:56.
patch diff of controllers.py (based on tg2_2.0.1)

Change History

06/30/09 17:01:11 changed by skyleach

  • attachment stacktrace_tg2.0.1_formencode_1.2.2.txt added.

stack trace of exception.

06/30/09 17:06:56 changed by skyleach

  • attachment tg_2.0.1_controllers.py.patch added.

patch diff of controllers.py (based on tg2_2.0.1)

06/30/09 17:11:16 changed by skyleach

fyi, ticket #1999 may have some additional changes that may make use of the 'domain' keyword practical, but until someone more familiar can look at this or I can spend the time to fully understand it I think it is better for me to hand this off to someone more familiar with i18n and translations.

11/17/09 08:57:29 changed by jorge.vargas

  • severity changed from normal to minor.
  • milestone set to 2.1.

This seems like a valid concern and we should port it to 2.1 just like #1999 did for ToscaWidgets?

11/17/09 10:15:23 changed by jorge.vargas

actually I just read #2363 and this seems like a consequence of.

11/17/09 10:16:24 changed by jorge.vargas

  • status changed from new to closed.
  • resolution set to duplicate.

#2363 has a more general usecase.