Ticket #2344 (closed defect: duplicate)
formencode 1.2.2 sends 'domain' as a kwarg to trans
| Reported by: | skyleach | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.1rc1 |
| Component: | TurboGears | Version: | 2.0.1 |
| Severity: | minor | Keywords: | |
| Cc: |
Description
formencode (specifically version 1.2.2) has started sending a keyword argument list to implementation-specific translation methods.
I appologize for not knowing enough detail here to have specifically tracked down why 'domain' is being passed as a keyword, but as a temporary fix that is backwards-compatible I suggest making pylons_formencode_gettext accept kwargs.
stack trace and patch file for tg 2.0.1 included.
Attachments
-
stacktrace_tg2.0.1_formencode_1.2.2.txt
(4.8 KB) -
added by skyleach 3 years ago.
- stack trace of exception.
-
tg_2.0.1_controllers.py.patch
(838 bytes) -
added by skyleach 3 years ago.
- patch diff of controllers.py (based on tg2_2.0.1)
Change History
Changed 3 years ago by skyleach
-
attachment
stacktrace_tg2.0.1_formencode_1.2.2.txt
added
Changed 3 years ago by skyleach
-
attachment
tg_2.0.1_controllers.py.patch
added
patch diff of controllers.py (based on tg2_2.0.1)
comment:1 Changed 3 years ago by skyleach
fyi, ticket #1999 may have some additional changes that may make use of the 'domain' keyword practical, but until someone more familiar can look at this or I can spend the time to fully understand it I think it is better for me to hand this off to someone more familiar with i18n and translations.
comment:2 Changed 2 years ago by jorge.vargas
- Severity changed from normal to minor
- Milestone set to 2.1
This seems like a valid concern and we should port it to 2.1 just like #1999 did for ToscaWidgets?
comment:3 Changed 2 years ago by jorge.vargas
actually I just read #2363 and this seems like a consequence of.
stack trace of exception.