Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2396 (closed enhancement: fixed)

Opened 10 years ago

Last modified 9 years ago

TG1 Scheduler : Kronos has been updated upstream, we need to reflect improvements

Reported by: jon Owned by: vinces1979
Priority: normal Milestone: 1.5
Component: Scheduler Version: 1.1
Severity: normal Keywords: needs feedback, scheduler
Cc:

Description

Irmen de Jong has taken the code from TG (making it standalone) and updated it to be compatible with Python 2.6.

Can we get those improvements as well ?

URL of the new code :  http://www.razorvine.net/download/kronos.py

Change History

comment:1 Changed 10 years ago by Chris Arndt

  • Owner set to faide
  • Keywords needs feedback, scheduler added
  • Component changed from TurboGears to Scheduler
  • Milestone set to __unclassified__

Is there a changelog available? Where did you get information about this version?

Also, I see somebody has released the turbogears scheduler as a standalone package on PyPI:  http://pypi.python.org/pypi/TGScheduler. There are also Python 2.6 eggs available.

comment:2 Changed 10 years ago by chrisz

The only change in Irmen's module is the adaption to Py 2.6. The change in Py 2.6 is that scheduler.queue is now a property; the underlying attribute has been renamed to scheduler._queue; scheduler.queue returns a sorted list instead. Also, in Py 2.6 the queue events are now named tuples.

Not sure whether using the property, i.e. the sorted list, would be a mistake here, or whether Irmen did this only for performance reasons. Access as a normal tuple does also still work in Py 2.6 since named tuples are downward compatible to tuples.

comment:3 follow-up: ↓ 4 Changed 10 years ago by jorge.vargas

  • Type changed from defect to enhancement

Acording to the pypi package it is based on the file linked. If this is going to be updated it should be to the pypi package instead of just updating the bungled version

comment:4 in reply to: ↑ 3 Changed 10 years ago by Chris Arndt

  • Milestone changed from __unclassified__ to 1.5

Replying to jorge.vargas:

Acording to the pypi package it is based on the file linked.

If you look at  the source, you'll see it's based on the TurboGears version. Also its release.py file says it's version 1.1 whereas kronos.py says it's version 2.0.

If this is going to be updated it should be to the pypi package instead of just updating the bungled version

If we can be sure the package will not be abandoned, I'm all for maintaining the Scheduler as a separate extension package and removing it from TG1 in the 1.5 branch, in the same vein as TurboFeeds and other TG components, whcih could be made into extension packages. Though I would prefer that it was hosted on svn.turbogears.org. I see that the google code project lists several TG mainainers as project owners. We should contact them and ask them about the status of this package. If I'm not mistaken, it could even be shared between TG1 and TG2.

One further point to note is that we recently fixed a bug (r6886) in scheduler.py. We should check whether the other versions contain this fix too.

comment:5 follow-up: ↓ 8 Changed 10 years ago by Chris Arndt

  • Owner changed from faide to vinces1979

Vince has now migrated his TGScheduler package into our repository: source:project/TGScheduler. Im assigning this ticket to him so he can close it when he has integrated the upstream changes.

comment:6 follow-up: ↓ 7 Changed 10 years ago by Chris Arndt

Vince, can we close this ticket now?

comment:7 in reply to: ↑ 6 Changed 9 years ago by vinces1979

  • Status changed from new to closed
  • Resolution set to fixed

Replying to Chris Arndt:

Vince, can we close this ticket now?

Yeah Chris this has been implemented and tested

comment:8 in reply to: ↑ 5 Changed 9 years ago by chrisz

Replying to Chris Arndt:

Just for the records, TG 1.5 as of r7134 does now require TGScheduler as an external package.

Note: See TracTickets for help on using tickets.