Ticket #2446 (new defect)

Opened 2 months ago

Last modified 2 months ago

test_controllers broken with WebTest 1.2.1

Reported by: chrisz Assigned to: chrisz
Priority: normal Milestone: 1.1.x bugfix
Component: TurboGears Version: 1.1
Severity: normal Keywords: webtest, flash
Cc:

Description

After upgrading from WebTest 1.2 to 1.2.1 (44:1d23a69a73fa at bitbucket), the tests

  • test_flash_on_redirect and
  • test_flash_redirect_with_trouble_chars

in test_controllers are failing for both TG 1.1 and 1.5.

This probably has something to do with changed cookie and/or redirection handling in WebTest and needs to be investigated a bit.

Change History

01/26/10 09:56:31 changed by chrisz

Analyzed this and found that there are actually two problems:

First, after a recent change to WebTest, an additional pair of quotes can be wrongly added around cookie values. I'll try to clarify this with Ian.

Second, TG - via its util module - uses the URL quoting/unquoting mechanism for cookie values. This is different from the quoting/unquoting mechanism used by the Python Cookie module which is used for holding the request and response cookies. There may be incompatibilities or double encodings because of that. I'll investigate this further after the above issue with WebTest will be fixed.

01/29/10 13:16:17 changed by chrisz

Already fixed the second issue in r7012.

The WebTest bug still needs to be fixed to make our test suite pass again with the current WebTest trunk. Leaving this ticket open as a reminder.

01/29/10 21:46:28 changed by chrisz

  • milestone changed from 1.1.1 to 1.1.x bugfix.

01/30/10 06:02:50 changed by Chris Arndt

  • keywords changed from webtest flash to webtest, flash.
  • owner set to chrisz.

Nice catch!