[PATCH] Make override_template work for all content types

[lento]

At the moment override_template only works for the "text/html" engine, this small patch allows it to work for other content types.

As an example I use override_template to have a single controller serving javascripts generated at runtime from templates and return the result with a content_type of "text/javascript".

    @expose(content_type='text/javascript')
    def parsedjs(self, script):
        """
        Render the required javascript from a template of the same name (but
        with a .mak extension) as found in spam/templates/parsedjs/
        
        This is needed for javascripts that use config variables from spam or
        other variable data.
        """
        scriptname = os.path.splitext(script)[0]
        templatename = 'spam.templates.parsedjs.%s' % scriptname
        
        if config.get('use_dotted_templatenames', False):
            template = G.dotted_filename_finder.get_dotted_filename(
                                    templatename, template_extension='.mak')
            if not os.path.exists(template):
                raise HTTPNotFound
        
        override_template(self.parsedjs, 'mako:%s' % templatename)

        return dict()

[jorge.vargas]

Use case looks weird but the patch is ok.

[chrisz]

The checked in patch is flawed (see also  here): First and worst, template is changed during the loop. Second, the override_mapping should not be set in every round of the loop. See attached proposed fix.

The other big flaw that I have not fixed is that there is no unit test or integration test for this function.

[chrisz]

Proposed fix of already checked in patch

[pedersen]

Migrated to  https://sourceforge.net/p/turbogears2/tickets/79/