Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #2483 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

[PATCH] Identity SecureObject does not proxy cherrypy attributes (like a _cp_filters)

Reported by: xaka Owned by: Chris Arndt
Priority: high Milestone: 1.1.2
Component: Identity Version: 1.1 HEAD
Severity: major Keywords:
Cc:

Description 

class Filter(BaseFilter):
  def before_main(self):
    pass

class ChildController(Controller):
  _cp_filters = [Filter()]

class ParentController(Controller, SecureResource):
  child = ChildController()

No one filter from _cp_filters list will be applied because of the bug.

Patch attached. Tests results: 

----------------------------------------------------------------------
Ran 446 tests in 72.001s

OK

and svn info: 

URL: http://svn.turbogears.org/branches/1.1
Repository Root: http://svn.turbogears.org
Repository UUID: 77541ad4-5f01-0410-9ede-a1b63cd9a898
Revision: 7052
Node Kind: directory
Schedule: normal
Last Changed Author: chrisz
Last Changed Rev: 7050

Attachments

turbogears.patch Download (2.0 KB) - added by xaka 8 years ago.

Change History

Changed 8 years ago by xaka

comment:1 Changed 8 years ago by chrisz

  • Milestone changed from __unclassified__ to 1.1.2

comment:2 Changed 8 years ago by chrisz

Patch applied in r7166. Thanks and sorry for the delay.

comment:3 Changed 8 years ago by chrisz

  • Status changed from new to closed
  • Resolution set to fixed

comment:4 Changed 8 years ago by chrisz

Patch improved in r7172.

Note: See TracTickets for help on using tickets.