Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #271 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] Default submit button for DataController is empty

Reported by: Jorge Godoy <jgodoy@…> Owned by: anonymous
Priority: normal Milestone:
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

After suggesting that the default "value" for the submit buttons be empty -- base.py on turbogears/widgets/ -- and a change made by Kevin Dangoor, the default value changed from "Submit" to "" leaving the button with no label at all.

The idea is to remove the value attribute if the user didn't specify it, making it appears as what the browser is configured to show in the chosen language that it is being used.

Attachments

submit-fix.patch Download (928 bytes) - added by KarlGuertin 13 years ago.
Noticed this when I was messing with the Forms patches

Change History

Changed 13 years ago by KarlGuertin

Noticed this when I was messing with the Forms patches

comment:1 Changed 13 years ago by anonymous

  • Summary changed from Default submit button for DataController is empty to [PATCH] Default submit button for DataController is empty

comment:2 Changed 13 years ago by kevin

  • Status changed from new to closed
  • Resolution set to fixed

The patch in #306 (committed in [418]) takes care of this.

Note: See TracTickets for help on using tickets.