Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #304 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] Widgets enhancements

Reported by: michele Owned by: anonymous
Priority: normal Milestone: 0.9
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

This patch provides:

  • consistent namings for widgets ids and classes:
field_label
field_error
[text | password | button | image | file | hidden]_field
textarea_field
fieldset_field
fieldset_field_element
select_field
[radio | checkbox]_field
[radio | checkbox]list_field
date_field (date_field_button)
datetime_field (datetime_field_button)
  • label are now working as they are supposed to do (this means that if you click on a label focus goes to the right field)
  • options parameter moved to the OptionsWidget? class and signed as a list (should also fix #299 I think)
  • a fix for #271. Note that it's different from the two solution provided by Karl (in #271) and Luca (in #301 and #302), dunno what's the best one.

Attachments

widgets.patch Download (23.2 KB) - added by michele 13 years ago.
Against r412

Change History

Changed 13 years ago by michele

Against r412

comment:1 Changed 13 years ago by michele

  • Summary changed from [PATCH] Widgets enchaments to [PATCH] Widgets enhancements

Doh! myspelled subject! It's morning here! :-)

comment:2 Changed 13 years ago by kevin

  • Status changed from new to closed
  • Resolution set to fixed

Committed in [418]. Thanks!

comment:3 Changed 13 years ago by kevin

  • Status changed from closed to reopened
  • Resolution fixed deleted

I forgot to run the tests before committing this. A bunch of things fail after this patch...

comment:4 Changed 13 years ago by michele

Sorry Kevin, can I know what failed? I will fix it immediatly hopefully.

comment:5 Changed 13 years ago by kevin

  • Status changed from reopened to closed
  • Resolution set to fixed

tests are fixed and the patch is recommitted in [421].

Note: See TracTickets for help on using tickets.