Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #315 (closed enhancement: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] Change form_errors to be validation_errors

Reported by: michele Owned by: anonymous
Priority: normal Milestone: 0.9
Component: TurboGears Version:
Severity: normal Keywords:
Cc:

Description

Link to the  discussion

Attachments

validation_errors.patch Download (8.3 KB) - added by michele 13 years ago.
Here we go
validation_errors-2.patch Download (9.5 KB) - added by michele 13 years ago.
Against last revision

Change History

comment:1 Changed 13 years ago by michele

  • Milestone set to 0.9

I'm targeting 0.9.

I think we can't change this after 0.9 because many people will be using form_errors.

By the way that's really a pretty trivial patch, find/replace paying attention and you are done.

Changed 13 years ago by michele

Here we go

comment:2 Changed 13 years ago by michele

  • Summary changed from Change form_errors to be validation_errors to [PATCH] Change form_errors to be validation_errors

comment:3 Changed 13 years ago by michele

Mmm, I will post an updated version because with my last changes this will not apply I think.

comment:4 Changed 13 years ago by kevin

  • Summary changed from [PATCH] Change form_errors to be validation_errors to Change form_errors to be validation_errors

Simon Belak is also about to hand in a completely new error handler, so I wouldn't bother making a new patch right now.

comment:5 Changed 13 years ago by michele

Ok. ;-)

Changed 13 years ago by michele

Against last revision

comment:6 Changed 13 years ago by michele

  • Summary changed from Change form_errors to be validation_errors to [PATCH] Change form_errors to be validation_errors

New version.

I've changed only references to cherrypy.request this time (as it should be) not also the variable named form_errors, luckily the first patch was not applied. :D

I hope we can get this in, if someone can test, nosetests runs fine as before here.

I grepped every directory for form_errors but missing something can be easy.

I hope it's good.

comment:7 Changed 13 years ago by alberto

  • Status changed from new to closed
  • Resolution set to fixed

Ooops, forgot about this one... Looks good from a nosetest POV. Committed 2 at r715. Thanks!

Note: See TracTickets for help on using tickets.