Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #349 (closed enhancement: wontfix)

Opened 13 years ago

Last modified 10 years ago

[PATCH] CatWalk: Paging support for MultipleJoins

Reported by: anonymous Owned by: anonymous
Priority: high Milestone: 1.x
Component: Toolbox.Catwalk Version:
Severity: major Keywords:
Cc:

Description

There is currently no paging support for MultipleJoins?. Hence, if you view a multiple join that has 1000+ columns, the browser will try to render 1000+ rows.

The attached patches to turbogears/toolbox/catwalk/init.py and catwalk.js add paging support to multiple joins, limiting the view of the multiple join to 10 entries at a time

Attachments

catwalk-multiple-joins-pages.diff Download (3.5 KB) - added by bbockelm@… 13 years ago.
Patch to catwalk python file
catwalk-js-multiple-joins-pages.diff Download (6.5 KB) - added by bbockelm@… 13 years ago.
Patch to catwalk javascript file
catwalk-multiple-joins-pages.2.diff Download (4.4 KB) - added by bbockelm@… 13 years ago.
Updated patch
catwalk-js-multiple-joins-pages.2.diff Download (12.4 KB) - added by bbockelm@… 13 years ago.
Updated patch

Change History

Changed 13 years ago by bbockelm@…

Patch to catwalk python file

Changed 13 years ago by bbockelm@…

Patch to catwalk javascript file

comment:1 Changed 13 years ago by ronald@…

I tried the patch but it breaks the following things:

  • Related joins grid's in object preview

If you take for example turboTunes, the grid for Artist genres doesn't work

  • 'update columns visibility breaks as well, after updating the column the grid doesn't reload the same 'page view' but load the complete list at the bottom the pager show page 1 of NaN
  • Selecting or trying to edit the records doesn't work either, because the requests are made on the context of the parent/host object
  • After adding a new Multiple Join the grid view should load at the last page
  • After editing, selecting or removing a multiple join the page view should load the same page, not the first one.

Changed 13 years ago by bbockelm@…

Updated patch

Changed 13 years ago by bbockelm@…

Updated patch

comment:2 Changed 13 years ago by bbockelm@…

Posted updated patches to address the above concerns.

comment:3 Changed 13 years ago by florian

Is this in and working?

For multiple joins I still can neither view or add any columns other then the first 10.

comment:4 Changed 13 years ago by anonymous

  • Priority changed from normal to high

comment:5 Changed 13 years ago by bjourne@…

The patch doesn't apply cleanly anymore. But it would still be really nice if CatWalk had this feature.

comment:6 Changed 13 years ago by michele

  • Summary changed from [PATCH] Paging support for MultipleJoins to [PATCH] CatWalk: Paging support for MultipleJoins

comment:7 Changed 13 years ago by jorge.vargas

  • Severity changed from normal to major
  • Milestone changed from 0.9 to 1.0

comment:8 Changed 13 years ago by jorge.vargas

  • Component changed from Toolbox to Toolbox.Catwalk

comment:9 Changed 13 years ago by jorge.vargas

  • Milestone changed from 1.0 to 1.0b2

lets decide if this goes or not

comment:10 Changed 12 years ago by alberto

  • Milestone changed from 1.0b2 to 1.1

comment:11 Changed 12 years ago by alberto

  • Milestone changed from 1.1 to __unclassified__

Batch moved into unclassified from 1.1 to properly track progress on the later

comment:12 Changed 10 years ago by jorge.vargas

  • Milestone changed from __unclassified__ to 1.x

comment:13 Changed 10 years ago by Chris Arndt

  • Status changed from new to closed
  • Resolution set to wontfix

Cruft ticket. Obsolete patch. CatWalk has no maintainer. Closing ticket as wontfix.

Note: See TracTickets for help on using tickets.