Ticket #349 (new enhancement)

Opened 2 years ago

Last modified 7 months ago

[PATCH] CatWalk: Paging support for MultipleJoins

Reported by: anonymous Assigned to: anonymous
Priority: high Milestone: __unclassified__
Component: Toolbox.Catwalk Version:
Severity: major Keywords:
Cc:

Description

There is currently no paging support for MultipleJoins?. Hence, if you view a multiple join that has 1000+ columns, the browser will try to render 1000+ rows.

The attached patches to turbogears/toolbox/catwalk/init.py and catwalk.js add paging support to multiple joins, limiting the view of the multiple join to 10 entries at a time

Attachments

catwalk-multiple-joins-pages.diff (3.5 kB) - added by bbockelm@math.unl.edu on 01/04/06 22:45:33.
Patch to catwalk python file
catwalk-js-multiple-joins-pages.diff (6.5 kB) - added by bbockelm@math.unl.edu on 01/04/06 22:46:19.
Patch to catwalk javascript file
catwalk-multiple-joins-pages.2.diff (4.4 kB) - added by bbockelm@math.unl.edu on 01/07/06 09:53:28.
Updated patch
catwalk-js-multiple-joins-pages.2.diff (12.4 kB) - added by bbockelm@math.unl.edu on 01/07/06 09:53:42.
Updated patch

Change History

01/04/06 22:45:33 changed by bbockelm@math.unl.edu

  • attachment catwalk-multiple-joins-pages.diff added.

Patch to catwalk python file

01/04/06 22:46:19 changed by bbockelm@math.unl.edu

  • attachment catwalk-js-multiple-joins-pages.diff added.

Patch to catwalk javascript file

01/05/06 15:10:15 changed by ronald@checkandshare.com

I tried the patch but it breaks the following things:

  • Related joins grid's in object preview

If you take for example turboTunes, the grid for Artist genres doesn't work

  • 'update columns visibility breaks as well, after updating the column the grid doesn't reload the same 'page view' but load the complete list at the bottom the pager show page 1 of NaN
  • Selecting or trying to edit the records doesn't work either, because the requests are made on the context of the parent/host object
  • After adding a new Multiple Join the grid view should load at the last page
  • After editing, selecting or removing a multiple join the page view should load the same page, not the first one.

01/07/06 09:53:28 changed by bbockelm@math.unl.edu

  • attachment catwalk-multiple-joins-pages.2.diff added.

Updated patch

01/07/06 09:53:42 changed by bbockelm@math.unl.edu

  • attachment catwalk-js-multiple-joins-pages.2.diff added.

Updated patch

01/07/06 09:55:07 changed by bbockelm@math.unl.edu

Posted updated patches to address the above concerns.

01/16/06 11:27:45 changed by florian

Is this in and working?

For multiple joins I still can neither view or add any columns other then the first 10.

01/16/06 14:41:53 changed by anonymous

  • priority changed from normal to high.

02/15/06 17:24:57 changed by bjourne@gmail.com

The patch doesn't apply cleanly anymore. But it would still be really nice if CatWalk had this feature.

04/11/06 16:25:34 changed by michele

  • summary changed from [PATCH] Paging support for MultipleJoins to [PATCH] CatWalk: Paging support for MultipleJoins.

09/23/06 15:39:02 changed by jorge.vargas

  • severity changed from normal to major.
  • milestone changed from 0.9 to 1.0.

09/23/06 17:49:39 changed by jorge.vargas

  • component changed from Toolbox to Toolbox.Catwalk.

09/23/06 23:15:01 changed by jorge.vargas

  • milestone changed from 1.0 to 1.0b2.

lets decide if this goes or not

01/11/07 14:52:45 changed by alberto

  • milestone changed from 1.0b2 to 1.1.

03/28/07 12:42:00 changed by alberto

  • milestone changed from 1.1 to __unclassified__.

Batch moved into unclassified from 1.1 to properly track progress on the later