Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #358 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] Avoid the name attribute for submit widgets

Reported by: michele Owned by: anonymous
Priority: normal Milestone: 0.9
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

The attached patch should solve the problem and the need of stripping them away.

The SubmitButtonList? is a bit unclear I've removed the option used but we should ask Dan Jaboc to check this probably.

Topic is  here

Attachments

submit.patch Download (1.8 KB) - added by michele 13 years ago.
The patch

Change History

Changed 13 years ago by michele

The patch

comment:1 Changed 13 years ago by anonymous

Will this track the submit button value if the value was explicitly declared like talked about in the mailing list?

comment:2 Changed 13 years ago by KarlGuertin

  • Status changed from new to closed
  • Resolution set to fixed

Didn't mention it on the patch notes (lost track of one ticket) but this is committed in r522. If the submit widget is given a specific name (not 'submit') it will show up in the results. I also keep the value if you're using a SubmitList? widget.

Either way, you're intentionally adding a submit button to the form (rather than just having one added by TG) and as a result you should be dealing with the submit button.

comment:3 Changed 13 years ago by michele

  • Status changed from closed to reopened
  • Resolution fixed deleted

I think it's a bit strange and magic that if you give to your submit button the "submit" name it gets stripped while otherwise it's not stripped.

Can't we just check if the name was provided and in that case add it? If I provide a name to a submit widget it means that I want to track it even if I call it submit.

That's just my impression, but it's strange that if I give it the submit name it stripped, that's a wrong assumption from my POV.

comment:4 Changed 13 years ago by Karl Guertin <grayrest@…>

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in r529. Despite what the commit message says.

comment:5 Changed 13 years ago by Karl Guertin <grayrest@…>

That's #528. I'm having number dyslexia tonight.

comment:6 Changed 13 years ago by Karl Guertin <grayrest@…>

r528, like I meant to say.

Note: See TracTickets for help on using tickets.