Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #466 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

Newest cherrypy trunk breaks std.url

Reported by: jchu@… Owned by: anonymous
Priority: highest Milestone: 0.9
Component: TurboGears Version:
Severity: normal Keywords:
Cc:

Description

The traceback ends with:

AttributeError: 'Request' object has no attribute 'app_path'

Turns out that cherrypy has gotten rid of the app_path and gone with mount_points (that's what it says in the commit log).

Here's a patch to make std.url follow suit. Without it, all pages that use std.url won't work.

Attachments

mount_point.patch Download (536 bytes) - added by jchu@… 13 years ago.
test_controllers.diff Download (1.1 KB) - added by mbrubeck@… 13 years ago.
Additional fix for approot tests using cherrypy.tree.mount().

Change History

Changed 13 years ago by jchu@…

comment:1 Changed 13 years ago by Max <ischenko@…>

Looks like it didn't work. At least, if I install latest cherrypy and apply your patch some tests still fail. Can anyone else confirm that?

comment:2 Changed 13 years ago by anonymous

  • Summary changed from Newest cherrypy trunk breaks std.url to [PATCH] Newest cherrypy trunk breaks std.url

Changed 13 years ago by mbrubeck@…

Additional fix for approot tests using cherrypy.tree.mount().

comment:3 Changed 13 years ago by Helio Pereira

  • Milestone set to 0.9

Have tested patch in util.py and it works fine... tks.

comment:4 Changed 13 years ago by kevin

This patch is part of the solution. I would like to avoid having to make explicit calls to cherrypy.tree.mount. The basic idea is that when an app is spotted the first time through normal traversal, it is mounted at that time. I need to go back through my exchange with Robert Brewer, but I think we can do this with a getattr hook.

comment:5 Changed 13 years ago by kevin

In the meantime, I have committed these two patches in [599].

comment:6 Changed 13 years ago by kevin

  • Summary changed from [PATCH] Newest cherrypy trunk breaks std.url to Newest cherrypy trunk breaks std.url

comment:7 Changed 13 years ago by kevin

Ignore this comment.

comment:8 Changed 13 years ago by kevin

  • Status changed from new to closed
  • Resolution set to fixed

This is now fixed.

Note: See TracTickets for help on using tickets.