Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #532 (closed enhancement: fixed)

Opened 13 years ago

Last modified 13 years ago

[PATCH] css_classes support, some fixes, some tests

Reported by: michele Owned by: anonymous
Priority: normal Milestone: 0.9
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

This patch adds back css_classes support to FormField?.

I think that ultimately we should move the field_class, field_id (and changing their names) along with to css_classes to the SimpleWidget? but I won't have time to do it.

I've also included tests for this feature and the new field_for feature.

Finally I've corrected two typos on CheckBoxList? and RadioButtonList? and reverted the change made to some (4 I think) __init__ methods by Alberto that followed my wrong suggestion, this is just to keep consistency. :-)

One more thing, Calendar* and AutoCompleteField should be corrected to:

  • use name as the first parameter to __init__
  • call the super method before doing anything, not at the end

Attachments

css_classes.patch Download (6.6 KB) - added by michele 13 years ago.
The patch
css_classes_2.patch Download (6.5 KB) - added by michele 13 years ago.
Last version.

Change History

Changed 13 years ago by michele

The patch

comment:1 Changed 13 years ago by michele

I'm going to attach an updated version, and I think field_class, field_id management should be kept at the FormField? since we have FormField? that are not SimpleWidget?.

Changed 13 years ago by michele

Last version.

comment:2 Changed 13 years ago by alberto@…

  • Status changed from new to closed
  • Resolution set to fixed

Committed 2 at r697. Thanks!

P.S. I miss #490... :)

comment:3 Changed 13 years ago by michele

:D

Note: See TracTickets for help on using tickets.