Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #555 (closed enhancement: fixed)

Opened 9 years ago

Last modified 7 years ago

[PATCH] Form tweaks

Reported by: alberto Owned by: anonymous
Priority: normal Milestone: 0.9
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

I've done several little tweaks to Form widget. I'll post them first as a patch for the API designers to comment as I might be missing something on the intended semantics.

Basically what I've done is a small tweak to the Form ctor. to support declarative style forms. 100% backwards compatible and, IMO, more consistent with the rest of the API. See tests in the patch an example.

Attachments

declarative_forms.patch Download (3.2 KB) - added by alberto 9 years ago.

Change History

Changed 9 years ago by alberto

comment:1 Changed 9 years ago by alberto

The same should apply IMO to FieldSet?.

comment:2 Changed 9 years ago by michele

Seems all good to me.

That's not really a declarative form but a different form class that once instanced is ready to be used. ;)

Yes, I think you can do the same for the FieldSet?.

comment:3 Changed 9 years ago by alberto

  • Status changed from new to closed
  • Resolution set to fixed

Oh, I thought "declarative" was referring to fact that attributes were set on "declaration" time... :/ I guess I need to learn more of this OO terminology. Thanks, you never go to bed wihout lerning something new :D

I've committed at a polished version of this at r749

comment:4 Changed 9 years ago by michele

Well your vision is also right I think, but don't bother too much as this declarative thing it's not so clean from an OOP POV IMHO and too much subjective. :D

Note: See TracTickets for help on using tickets.