Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #615 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] widget.js render empty cells wrong

Reported by: bjourne Owned by: anonymous
Priority: normal Milestone:
Component: TurboGears Version:
Severity: normal Keywords:
Cc:

Description

You have a cell like this:

cell = {};
cell.value = '';
cell.column = 'name';

The code in Widget.grid.renderRows will check if the cell.value attribute exists using Widget.exists. That function will return false so the code will use the cell dict itself to render the cell and it will show up as "[Object object]". The patch makes it so Widget.exists doesn't evalute val so that in case val is 0 or "" it still renders properly.

Attachments

fix-widget.js-widget.exists.patch Download (374 bytes) - added by bjourne 13 years ago.

Change History

Changed 13 years ago by bjourne

comment:1 Changed 13 years ago by kevin

  • Status changed from new to closed
  • Resolution set to fixed

Committed in [832]. I'm also running it by Max to see if there's any gotchas or any other reason why that && val was there.

Note: See TracTickets for help on using tickets.