Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #658 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] identity framework makes use of "Deprecated" visit.id field

Reported by: jtate@… Owned by: anonymous
Priority: high Milestone: 0.9a5
Component: Identity Version: 0.8
Severity: normal Keywords: identity visit
Cc: jeff

Description

When using the identity framework as implemented in SVN, cherrypy dumps a DeprecationWarning? to the screen on every identity access.

The patch soon to be attached makes use of the visit.key field instead of the id.

Attachments

visit_id2visit_key.patch Download (6.1 KB) - added by jtate@… 13 years ago.
Patch to fix visit.id deprecation warning. Would break existing visit/identity implementations.
visit-key.patch Download (6.1 KB) - added by jtate@… 13 years ago.
New patch against r1050

Change History

Changed 13 years ago by jtate@…

Patch to fix visit.id deprecation warning. Would break existing visit/identity implementations.

comment:1 Changed 13 years ago by simon

  • Cc jeff added
  • Component changed from CherryPy to Identity

comment:2 Changed 13 years ago by kevin

  • Summary changed from identity framework makes use of "Deprecated" visit.id field to [PATCH] identity framework makes use of "Deprecated" visit.id field

Changed 13 years ago by jtate@…

New patch against r1050

comment:3 Changed 13 years ago by kevin

I've asked Jeff about this and his response, thus far, has been that he didn't want to break existing visit plugins. If visit.id is truly deprecated, then we'd want the framework to try to do the right thing (visit.key) as much as possible, while not breaking for people who already have code using the old method.

comment:4 Changed 13 years ago by jtate@…

It's not evil to use the visit.id field IMO, but it currently raises a Deprecation warning. I personally would rather use the id as it gives me (using the python database bindings that I use) easier access to the data.

The number of visit plugins that exist in the wild right now is probably very small. If to the tg_admin script a routine was added to drop and recreate the visit table, the "upgraded" app would start with no sessions (session data is temporary by definition anyway).

How would you know if code used the old method?

comment:5 Changed 13 years ago by michele

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 0.9 to 0.9a5

Fixed by Jeff in r1107.

Note: See TracTickets for help on using tickets.