Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #706 (closed enhancement: fixed)

Opened 12 years ago

Last modified 10 years ago

[PATCH] FastDataGrid doesn't support DataGrid.Column field arguments

Reported by: bloodearnest@… Owned by: anonymous
Priority: normal Milestone:
Component: TG Widgets Version:
Severity: normal Keywords:
Cc:

Description

In datawidgets.py , FastDataGrid?._prepare_fields() checks fields for backwards compatabiliy (line 56). It converts old style field arguments (single stings) into DataGrid.Columns. Problem is it doesn't check if the field is already an instance of DataGrid.Column, and tries to add a string to it, causing a TypeError? when doing "name + 'ID'" on line 61, since name is a Column.

Trivial patch follows

p.s Is the backwards compatibilty still important? Can it all go?

Attachments

patch.diff Download (196 bytes) - added by bloodearnest@… 12 years ago.
patch

Change History

Changed 12 years ago by bloodearnest@…

patch

comment:1 Changed 12 years ago by anonymous

  • Summary changed from FastDataGrid doesn't support DataGrid.Column field arguments [PATCH] to [PATCH] FastDataGrid doesn't support DataGrid.Column field arguments

Just reworded summary to include [PATCH] at the begining of the line instead of end for pending patch report.

comment:2 Changed 12 years ago by max

  • Status changed from new to closed
  • Resolution set to fixed

I applied the patch in r1052.

As for backward-compatibility - can't say for sure. I opened separate ticket for this, see #708.

Note: See TracTickets for help on using tickets.